Skip to content

Conversation

@mzarnecki
Copy link
Contributor

Change Log

Added

Fixed

  • fixed unit testing csv load overwrite mode

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.129mb -0.00%  | 763.171ms -2.80% | ±1.60% +69.38% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.782mb +0.00%   | 342.387ms -1.11% | ±0.58% +18.64% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.877mb +0.00%   | 978.175ms -1.37% | ±0.34% -79.03% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.581mb +0.00% | 1.146s -0.86%    | ±0.33% -45.08% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.661mb +0.00%   | 55.569ms +0.99%  | ±1.05% +53.13% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.663mb +0.00%   | 465.319ms -3.60% | ±1.36% +28.11% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.375mb +0.00% | 63.131ms -1.46% | ±0.75% -17.56% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.739mb +0.00%  | 451.060ms -7.03% | ±0.13% -94.20% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.820mb +0.00%  | 71.078ms -5.16%  | ±0.18% -88.93% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.333mb +0.00% | 57.754ms -5.86%  | ±1.51% -40.07% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.543mb +0.00% | 1.274s -0.63%    | ±0.28% -25.46% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.703mb +0.00%  | 41.200ms -0.93%  | ±0.35% -24.75% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.992mb +0.00% | 391.475ms -2.77% | ±0.41% -78.72%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.710mb +0.00%  | 199.828ms -2.41% | ±0.48% -84.85%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.835mb +0.00%  | 40.558ms -4.95%  | ±0.99% -8.46%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.398mb +0.00%  | 330.735ms -1.39% | ±0.67% -69.72%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.321mb +0.00%  | 65.604ms -1.34%  | ±0.10% -64.52%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 3.317ms -3.57%   | ±1.76% +35.31%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.249mb +0.00%  | 181.366ms -4.24% | ±1.83% +6.07%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.775mb +0.00%  | 18.249ms -2.70%  | ±0.72% -50.33%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 1.685ms -6.94%   | ±2.96% +6.88%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 1.840ms -0.15%   | ±1.46% +37.37%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.808ms +2.51%   | ±1.91% +66.86%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 14.890ms -0.01%  | ±1.97% +1.11%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 14.537ms -4.17%  | ±1.15% -45.33%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 1.806μs +0.68%   | ±2.57% -3.64%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.796mb +0.00%  | 13.043ms +0.05%  | ±2.44% +134.01% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.156mb +0.00% | 63.847ms -2.91%  | ±0.30% -85.95%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.337ms -6.13%   | ±3.61% +84.28%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.204mb +0.00%  | 57.764ms -1.61%  | ±1.93% +78.06%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.958mb +0.00%  | 4.016ms -0.39%   | ±1.55% +418.70% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 39.592ms -3.26%  | ±0.64% -63.08%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 39.280ms -4.16%  | ±0.63% -36.59%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 40.313ms -4.73%  | ±1.07% -64.04%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.682mb +0.00%  | 7.426ms -1.85%   | ±0.63% -38.85%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 29.344ms -2.65%  | ±1.60% +87.20%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 13.752μs +3.26%  | ±3.84% +263.88% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 15.821μs -0.42%  | ±0.79% -51.68%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 182.290ms -2.46% | ±0.73% +28.01%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

Copy link
Member

@stloyd stloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@norberttech norberttech merged commit f6d1e32 into flow-php:1.x Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants