Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • group by uuid/datetime objects without casting them to scalar first

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.279mb +0.00%  | 826.600ms -1.11% | ±0.82% -47.90%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.002mb +0.00%   | 342.891ms +0.85% | ±0.55% -31.49%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.152mb +0.00%   | 1.061s +1.63%    | ±0.61% -8.21%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.818mb +0.00% | 905.172ms +0.59% | ±0.87% +134.00% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.910mb +0.01%   | 35.287ms -0.11%  | ±0.43% +11.88%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.915mb +0.01%   | 441.473ms +2.56% | ±0.60% -31.52%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.616mb +0.00% | 63.848ms -1.63% | ±1.21% +54.03% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.659mb +0.00%  | 465.762ms -1.63% | ±0.84% -1.82%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.141mb +0.00%  | 70.735ms -0.90%  | ±0.59% +16.83%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.567mb +0.00% | 52.671ms -0.21%  | ±0.67% +836.35% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 224.385mb +0.00% | 1.412s -1.54%    | ±1.06% +163.41% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.957mb +0.00%  | 39.984ms +0.08%  | ±0.24% -15.15%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.714mb +0.00% | 489.518ms -0.54% | ±0.63% +210.19%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.192mb +0.00%  | 249.599ms +0.05% | ±1.31% +24.53%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.127mb +0.00%  | 53.167ms +0.98%  | ±0.98% -32.35%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.958mb +0.00%  | 435.631ms +0.37% | ±0.30% -26.97%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.497mb +0.00%  | 86.418ms +1.61%  | ±0.95% -63.93%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.682mb +0.00%  | 3.638ms -0.89%   | ±2.65% +254.60%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.409mb +0.00%  | 181.640ms -0.69% | ±2.12% +76.86%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.935mb +0.00%  | 18.262ms -1.30%  | ±0.13% -87.46%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.922mb +0.00%  | 1.764ms +3.38%   | ±1.54% -30.89%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.922mb +0.00%  | 1.813ms +4.82%   | ±2.32% +55.53%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.034mb +0.00%  | 2.608ms +1.78%   | ±1.50% -37.42%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.563mb +0.00%  | 14.645ms +0.94%  | ±0.30% -87.46%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.563mb +0.00%  | 14.486ms -2.94%  | ±0.89% -49.55%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.468mb +0.00%  | 1.794μs -5.28%   | ±2.67% +5.66%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.468mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.022mb +0.00%  | 13.478ms +2.95%  | ±2.31% +987.76%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.383mb +0.00% | 66.181ms -3.08%  | ±0.57% -58.30%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.083mb +0.00%  | 1.480ms +10.58%  | ±0.39% -88.49%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.430mb +0.00%  | 57.197ms -0.78%  | ±0.71% +56.28%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.185mb +0.00%  | 3.894ms +1.14%   | ±0.57% -50.30%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.546mb +0.00%  | 39.292ms -2.62%  | ±1.33% +141.27%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.546mb +0.00%  | 39.722ms -0.95%  | ±1.61% -9.51%    |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.546mb +0.00%  | 39.453ms -3.35%  | ±0.84% -51.26%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.909mb +0.00%  | 7.569ms +3.80%   | ±1.75% +1799.15% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.468mb +0.00%  | 29.893ms +3.98%  | ±2.27% +59.46%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.468mb +0.00%  | 13.770μs +2.89%  | ±1.73% +8.04%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.468mb +0.00%  | 16.072μs -1.82%  | ±2.93% +101.74%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.476mb +0.00%  | 186.877ms -0.06% | ±0.41% +14.44%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 5eb5fc8 into flow-php:1.x Feb 21, 2024
@norberttech norberttech added this to the 0.7.0 milestone Mar 11, 2024
@norberttech norberttech deleted the fix/group-by-edge-cases branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant