-
Notifications
You must be signed in to change notification settings - Fork 155
Closed
Description
Describe the bug
GoogleServicesPlugin creates processDebugGoogleServices and processReleaseGoogleServices tasks eagerly by not using tasks.register().
To Reproduce
- Apply plugin to any (android) project with
plugins { id 'com.google.gms.google-services' version '4.3.5' } - Run
./gradlew --scan - Check build scan -> Performance -> Configuration
- Total tasks created immediately is equal to 2 and it's
processDebugGoogleServicesandprocessReleaseGoogleServicestasks
Expected behavior
Tasks are created during execution. GoogleServicesPlugin is Task Configuration Avoidance complaint. Migration steps and guideline is provided at the link.
Additional context
At the very least create needs to be replaced with register here https://github.com/google/play-services-plugins/blob/e40a3f6a7653f9f3b2b1421ca0a5d1cb8d62705c/google-services-plugin/src/main/groovy/com/google/gms/googleservices/GoogleServicesPlugin.groovy
Metadata
Metadata
Assignees
Labels
No labels