Make singleton return a slice of a static buffer
#480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Feb 2, 2022
Bodigrim
approved these changes
Feb 2, 2022
sjakobi
reviewed
Feb 2, 2022
sjakobi
approved these changes
Feb 3, 2022
Contributor
|
Thanks! |
sjakobi
pushed a commit
that referenced
this pull request
Feb 15, 2022
Bodigrim
pushed a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the effect of making newly-created singletons only require 4 rather than 9 words of heap space. Additionally, since the body of
singletonnow simplifies to a constructor application without anyrunRW#noise, this change enables GHC to perform more optimizations whensingletongets inlined than were previously possible.