Continuation of #942: additional float64 failure #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until #990 is addressed.
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Looks good to me, but @anton-l is the expert here :-) |
anton-l
approved these changes
Oct 26, 2022
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
Oof, even I got confused by self.timesteps vs timesteps for a minute here, we'll probably need a better name at some point 😅
Going back to the PR's purpose: looks good, thanks Pedro!
Member
Author
Yes, the same thing happened to me :) We have |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ace#996) * Add failing test for huggingface#940. * Do not use torch.float64 in mps. * style * Temporarily skip add_noise for IPNDMScheduler. Until huggingface#990 is addressed. * Fix additional float64 error in mps. * Improve add_noise test * Slight edit – I think it's clearer this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.