[CS2] Fix for comma after function glyph [#1043] #4588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one "unambiguous" thing I saw in #1043 was that a
,immediately following->or=>can indicate an empty function body, since otherwise it seems to be a syntax error (ie a function body can't start with a comma). So this uses the rewriter to interpret-> ,and=> ,that way@GeoffreyBooth I targeted
2, I guess this could safely go onmastersince the previous meaning was a syntax error, but you seem to prefer only targetingmasterif really necessary?