Fix json invalid utf-8 from IconPath #13340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When storing the IconPath value directly as a string we are subject to unspecified behaviour as Windows stores paths as 16-bit wchar_t and std::string doesn't convey a specific char encoding. To be specific we need to access the icon path in its native format (which we assume to be std::wstring) and convert it to multibyte.
CarlosNihelton
requested review from
OneBlue,
benhillis,
craigloewen-msft and
justus-camp-microsoft
Collaborator
|
Thank you for doing this @CarlosNihelton! I reproduced the issue, and validated the fix. |
OneBlue
approved these changes
Aug 5, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benhillis
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When storing into the json container the
IconPathvalue directly as astd::stringwe are subject to unspecified behaviour as Windows stores paths as 16-bitwchar_t,std::stringdoesn't convey a specific char encoding and thestd::filesystemlibrary doesn't mandate a specific conversion.We need to access the icon path in its native format (which we assume to be
std::wstring) and convert it to multibyte.Details in the linked issue: #13339
PR Checklist
Validation Steps Performed
Repeat the process described in the issue #13339 with a build containing the proposed fix.