Relaunch the debug shell if user exits it. #13379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
OneBlue,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the WSL debug shell by adding automatic relaunch functionality. When a user exits the debug shell (e.g., by typing "exit"), the shell will automatically restart instead of becoming permanently unusable.
- Wraps the debug shell process in a relaunch loop that monitors and restarts the shell when it exits
- Uses proper process management with waitpid to handle child process termination
- Maintains the same agetty configuration for the actual shell process
OneBlue
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #13330 I realized that it's not ideal that the debug shell will become unusable if the user runs "exit" in it. Resolve that issue by adding a relaunch loop.
This does not actually fix the reported issue, but I think is a useful change to take in isolation as it improves debugging capability.