Skip to content

Conversation

@OneBlue
Copy link
Collaborator

@OneBlue OneBlue commented Sep 12, 2025

Summary of the Pull Request

This should prevent future build breaks when nuget packages are updated

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue OneBlue requested a review from a team as a code owner September 12, 2025 21:10
Copilot AI review requested due to automatic review settings September 12, 2025 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds NuGet package lock files for the wslsettings target to prevent automatic version increases that could cause build breaks. The change implements package locking by enabling NuGet package restoration with lock files and creates platform-specific lock files to pin dependency versions.

  • Enables NuGet package lock file restoration in the build system
  • Creates platform-specific package lock files (x64, arm64, and generic) for wslsettings
  • Locks all NuGet package dependencies to specific versions to prevent automatic updates

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Directory.Build.Props Enables NuGet lock file restoration and sets platform-specific lock file paths
packages.lock.json Generic package lock file with all dependency versions pinned
packages.lock.arm64.json ARM64-specific package lock file
packages.lock.x64.json x64-specific package lock file with additional runtime dependencies

@OneBlue OneBlue changed the title Add lock files to wslsettings target to prevent automatic nuget version increases Set TargetLatestRuntimePatch to false to prevent automatic framework version increases Sep 16, 2025
@OneBlue OneBlue merged commit b9e74a3 into master Sep 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants