Fix WslDistributionConfig to not default-initialize optional fields #13629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etworkingMode optional fields
benhillis
requested review from
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in WslDistributionConfig where optional fields were incorrectly initialized with default values instead of remaining uninitialized. When mount.drvfs used a default-constructed config struct, it inadvertently used config flags of zero instead of querying init for the actual values, causing virtio9p and virtiofs test failures.
Key Changes:
- Removed default initialization values from
FeatureFlagsandNetworkingModeoptional fields, allowing proper detection of unset values
OneBlue
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with the virtio9p and virtiofs tests I noticed that some of the testcases were failing because they were attempting to mount the socket-based 9p shares. This was due to the mount.drvfs helper using default-constructed config struct, which was inadvertently using config flags of zero instead of querying init for the real flags value.