Add back WSL2_VM_ID environment variable to the system distro. #13835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the WSL2_VM_ID environment variable for the system distro (WSLg runtime environment) by conditionally preserving it when the system distro is detected. The change addresses a dependency in the weston mirror project where the VM ID is required. The logic uses the presence of LX_WSL2_SHARED_MEMORY_OB_DIRECTORY to distinguish system distros (which need the variable) from user distros (where it should remain unset for privacy).
Key changes:
- Modified environment variable cleanup logic to preserve
WSL2_VM_IDfor system distros while still removing it for user distros - Added conditional check using
LX_WSL2_SHARED_MEMORY_OB_DIRECTORYas the discriminator between distro types
hideyukn88
approved these changes
Dec 5, 2025
OneBlue
approved these changes
Dec 5, 2025
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
LGTM. We should also consider adding test coverage for the wslg shortcut creation logic (can be done in followup PR though)
benhillis
changed the title
2 tasks
OneBlue
pushed a commit
that referenced
this pull request
Dec 12, 2025
Co-authored-by: Ben Hillis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds back the VM ID environment variable to the system distro (WSLg runtime environment). Turns out weston has a dependency on this environment variable: https://github.com/microsoft/weston-mirror/blob/2318fecaeac1f1a2d5a7a042c34d931c71dae04c/rdprail-shell/shell.h#L56