Skip to content

CI: update issue for wslsettings being rebuilt and signature being overwritten #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benhillis merged 4 commits into from
Dec 11, 2025
Merged

CI: update issue for wslsettings being rebuilt and signature being overwritten #13855

benhillis merged 4 commits into from
Dec 11, 2025

Conversation

@benhillis
Copy link
Member

@benhillis benhillis commented Dec 8, 2025

This should prevent cmake from rebuilding the wslsettings project and overwriting the signature files.

@benhillis benhillis requested a review from a team as a code owner December 8, 2025 22:53

This comment was marked as outdated.

Sign in to view

@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch 2 times, most recently from 7264daf to 853f1fe Compare December 8, 2025 23:45
@benhillis benhillis requested a review from Copilot December 8, 2025 23:46
Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch from 853f1fe to b1bd954 Compare December 8, 2025 23:53
@benhillis benhillis requested a review from Copilot December 8, 2025 23:53
@benhillis benhillis changed the title CI: update issue for wslsettings being rebuilt and signature being ov… CI: update issue for wslsettings being rebuilt and signature being overwritten Dec 8, 2025
Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@benhillis
Copy link
Member Author

benhillis commented Dec 9, 2025

@OneBlue - unfortunately this didn't seem to work.

@benhillis benhillis requested a review from Copilot December 9, 2025 17:13
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch from b8e2b80 to 5435d18 Compare December 10, 2025 19:31
@benhillis benhillis requested a review from Copilot December 10, 2025 19:31
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

OneBlue
OneBlue reviewed Dec 10, 2025
View reviewed changes
@benhillis benhillis merged commit 5acd600 into master Dec 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@OneBlue OneBlue OneBlue approved these changes

@Brian-Perkins Brian-Perkins Awaiting requested review from Brian-Perkins Brian-Perkins is a code owner automatically assigned from microsoft/wsl-maintainers

@craigloewen-msft craigloewen-msft Awaiting requested review from craigloewen-msft craigloewen-msft is a code owner automatically assigned from microsoft/wsl-maintainers

@justus-camp-microsoft justus-camp-microsoft Awaiting requested review from justus-camp-microsoft justus-camp-microsoft is a code owner automatically assigned from microsoft/wsl-maintainers

Assignees

@OneBlue OneBlue

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benhillis @OneBlue