Skip to content

Conversation

@absci
Copy link
Contributor

@absci absci commented Jan 26, 2023

No description provided.

absci and others added 22 commits August 29, 2022 18:48
* Print error messages for managed identity test

* Skip appveyor MSI tests

* Skip msi tests for unix
* Reset column size

* Fix clientInfo related test cases (#1407)

* Create pdo_1391_string_truncation_after_short_string.phpt

Regresssion tests: Use the same Statement to insert a row with short strings first, and longer strings second.

- Issue also happens with VARCHAR( >=4002 ). Not just Max or NVARCHAR
- Issues 1391, 1393 (and possibly 1371 ?) might all have the same root cause.

* fetchAll() -> fetch(), we only want 1 row.

* Revert trigger

Co-authored-by: Maarten S <[email protected]>
appveyor have ODBC 13 installed on their test agent
@absci absci requested review from David-Engel and v-makouz January 26, 2023 19:30
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #1427 (ee5bacc) into master (109b8bc) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   83.61%   83.45%   -0.16%     
==========================================
  Files          22       22              
  Lines        7853     7851       -2     
==========================================
- Hits         6566     6552      -14     
- Misses       1287     1299      +12     
Impacted Files Coverage Δ
...s16/x86/php-8.0.19-src/ext/sqlsrv/php_sqlsrv_int.h
...phpdev/vs16/x86/php-8.0.19-src/ext/sqlsrv/init.cpp
...s16/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_util.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_conn.cpp
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_sqlsrv.h
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_stmt.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
...6/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_parser.cpp
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_conn.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_util.cpp
... and 34 more

@absci absci merged commit afdc9b6 into master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants