Modifying conditional breakpoints while debugging does not work due to VSCode change

[WardenGnaw]

VS Code version: 1.25.1

Steps to reproduce

Create C++ project and create a conditional breakpoint that will be true. Start debugging. Once you hit the breakpoint, change it to a false statement. F5.

Expected behavior

Once it becomes a false statement, it should not hit the breakpoint.

Actual behavior

It will always hit the breakpoint due to the original condition

Issue reason:

VSCode changed how they updated breakpoints. Instead of removing then adding a new breakpoint, they use the same breakpoint id.

See: microsoft/vscode#42200

[letmaik]

This is also a problem if you start with a regular breakpoint and make it a conditional breakpoint. In that case, the condition is not applied and the breakpoint stays a regular breakpoint. I could verify this with "engineLogging": true in the debug console: no gdb commands are sent when modifying the breakpoint.

[salda]

How to upvote it?

[bobbrow]

Click the reaction icon and choose the 👍

[salda]

Thanks, I did it before, just wasn't sure it's it.

[jerome-labidurie]

As a workaround, breakpoints can still be modified in gcc via the debugging console :
-exec cond <breakpoint_number> <condition>
eg:
-exec cond 2 pStruct != 0x0
obviously, it will not be visible in the GUI :(

[g3v]

The issue is still present. I thought I am losing it :)

[aenima1891]

Please, solve this issue.
It would be very useful during debugging

[nicole-mcg]

I am getting behaviour where once the conditional breakpoint is hit once, it is no longer conditional

[lbru]

Issue still reproducible on 1.40.2. Workaround described in #2297 (comment) still applies.

[abemud]

the issue is still here!