readme and add_site_option fix #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…required sessions.
…to error messages in the Apache log due to the value of $wpdb->sitemeta
Errors are similar to:
[Thu Apr 03 21:03:06 2014] [error] [client XX.XX.XX.XX] WordPress database error You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to use near
'WHERE meta_key = 'shibboleth_logout_url' AND site_id = 0' at line 1 for query SELECT meta_value FROM WHERE meta_key = 'shibboleth_logout_url' AND site_id = 0 made by activate_plugin, do_action('activate_shibboleth/shibboleth.php'),
call_user_func_array, shibboleth_activate_plugin, shibboleth_add_option,
referer: http://wpdev.hvcc.edu/wordpress/wp-admin/plugins.php?deactivate=true&plugin_status=all&paged=1&s=
Note the blank space between FROM and WHERE.
mitcho
added a commit
that referenced
this pull request
Apr 4, 2014
readme and add_site_option fix, props billjojo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mitcho, I've added the readme contents as you suggested. In retrospect, I was looking to add a bit too much control in the admin panel.
Also, the add_site_option code was fixed in 3.3.0, so I removed the check that was in place as in current version it throws error for every add - especially on non-multisite installs. I considered doing a version check, but people should be running a recent version anyway.
Thanks!