-
Notifications
You must be signed in to change notification settings - Fork 18.9k
pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail, remove DisplayJSONMessagesToStream and Stream interface #49264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail, remove DisplayJSONMessagesToStream and Stream interface #49264
Conversation
d4db89a to
73b0797
Compare
|
docker-py error could be legit, which means it's depending on the deprecated fields; |
73b0797 to
58048d0
Compare
69eb214 to
8d8ecd8
Compare
f8967b1 to
dac3a63
Compare
1a4ae99 to
45d370c
Compare
The API still returns it for backward-compatibility (but probably shouldn't), but we should no longer print it. This removes the use of these fields for printing, but keeps them for streamformatter to use. - ErrorMessage was deprecated in 3043c26 - ProgressMessage was deprecated in 597e0e6 Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was an adaptor around DisplayJSONMessagesStream for CLI-specific primitives that was used in the CLI, but can be implemented by users of this package. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was an interface to match CLI-specific primitives and is no longer used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
45d370c to
2b4506b
Compare
2b4506b to
f3ba0b2
Compare
|
I have some other changes in a local branch, but need to give those some thinking to see if we can still provide aliases with those. Effectively, I want to un-export most bits, and swap out the |
depends on these fixes to be released in docker-py;
pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail
The API still returns it for backward-compatibility (but probably
shouldn't), but we should no longer print it. This removes the
use of these fields for printing, but keeps them for streamformatter
to use.
client/pkg/jsonmessage: remove DisplayJSONMessagesToStream
It was an adaptor around DisplayJSONMessagesStream for CLI-specific
primitives that was used in the CLI, but can be implemented by users
of this package.
client/pkg/jsonmessage: remove Stream interface
It was an interface to match CLI-specific primitives and is no
longer used.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)