Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Nov 13, 2025

c8d/builder-next: Don't force unpack

The image exporter wrapper was unconditionally setting unpack=true for
all build exports, preventing users from controlling this behavior
through buildkit's output image exporter option.

containerd image store: Fix a bug causing `docker build` to ignore the explicitly set `unpack` image exporter option.

The image exporter wrapper was unconditionally setting `unpack=true` for
all build exports, preventing users from controlling this behavior
through buildkit's output image exporter option.

Signed-off-by: Paweł Gronowski <[email protected]>
(cherry picked from commit b4f9bd1)
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added this to the 29.0.1 milestone Nov 13, 2025
@vvoland vvoland self-assigned this Nov 13, 2025
@vvoland vvoland added area/builder Build status/2-code-review impact/changelog kind/bugfix PR's that fix bugs area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration labels Nov 13, 2025
@github-actions github-actions bot added the area/daemon Core Engine label Nov 13, 2025
@vvoland vvoland marked this pull request as ready for review November 13, 2025 19:53
@vvoland vvoland requested a review from thaJeztah November 13, 2025 20:57
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit 14c4e0d into moby:docker-29.x Nov 14, 2025
190 of 197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/builder/buildkit Build area/builder Build area/daemon Core Engine containerd-integration Issues and PRs related to containerd integration impact/changelog kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants