Allow array as presenter mapping

[enumag]

The PresenterFactory splits the mapping mask to 3 parts - a prefix, a part which is reapeated for each module and a part for presenter. The problem is that there is no way to actually configure the 3 parts separately. In my case I need the mapping to look like this:

'*' => array('App\', 'Module\*Module\', 'Presenter\*Presenter')

This is currently not possible to achieve. I tried the following:

nette.application:
    mapping:
        *: App\Module\*Module\Presenter\*Presenter
# result:
# '*' => array('App\Module\', '*Module\', 'Presenter\*Presenter')

nette.application:
    mapping:
        *: App\*Module\Module\Presenter\*Presenter
# result:
# '*' => array('App\', '*Module\', 'Module\Presenter\*Presenter')

To achieve the mapping I want I'd have to create my own PresenterFactory. And I can't even extend the default one because the mapping property is private (don't want to hack it using reflection).

Instead I'd like the PresenterFactory to accept an array as well so that this would work:

nette.application:
    mapping:
        *: [ App\, Module\*Module\, Presenter\*Presenter ]

[JanTvrdik]

👍

[Majkl578]

👎 It's even more obscure than current syntax. :(

[fprochazka]

I think it should be objects, then you would register

nette.application:
    mapping:
        *: Nette\Application\DefaultPresenterMapping("App\\", "Module\\*Module\\", "Presenter\\*Presenter")
        Custom: My\Custom\PresenterMapping()
        VeryCustom: @My\Custom\PresenterMapping() # find service in container

ofcourse, the default syntax could replace string for the Nette\Application\DefaultPresenterMapping due to compatibility, so you'd get

nette.application:
    mapping:
        *: App\Module\*Module\Presenter\*Presenter # interpreted as Nette\Application\DefaultPresenterMapping("App\Module\*Module\Presenter\*Presenter")
        Custom: My\Custom\PresenterMapping()
        VeryCustom: @My\Custom\PresenterMapping() # find service in container

and ofcourse, you'd have to implement an interface

class IPresenterMapping {
    public function formatPresenterClass($presenter);
    public function unformatPresenterClass($class);
}

Then PresenterFactory's only job would be to find the namespace in array and call the method.

[enumag]

@fprochazka Like! :-)

[lookyman]

@fprochazka That is beautiful 👍

[Unlink]

👍

[fprochazka]

Who's gonna implement it guys? :)

[dg]

@enumag maybe something like this is more readable than array:

nette.application:
    mapping:
        *: App\[Module\*Module]\Presenter\*Presenter

@fprochazka is not it overengeneered?

[enumag]

@dg It's not bad but I slightly prefer array. In most cases I like to keep things simple instead of inventing new syntaxes.

[fprochazka]

@dg I don't think so, because in the current way, you have to invent "new magic syntaxes" to add mapping options. But "my way", you can just code it in plain PHP and mainly you can easily write a unittest for it, without having to pipe it through PresenterFactory first.

[hrach]

@dg: please, do not create new metalanguages. I'd like more the verbose php solution, than something hidden in the strings. It's much more difficult to do tools which should support it (intellij-neon plugin), etc.

[dg]

It is not metalanguage, but domain-specific language.

[hrach]

@dg: please, do not create new domain-specific language. Reasons above.

[dg]

It already exists. App\Module\*Module\Presenter\*Presenter.

[hrach]

I don't claim I like it, I wanted to point out I would like it wouldn't get any new features.