Set charset for JsonResponse

[patrickkusebauch]

When sending a JsonResponse, you cannot set the JSON charset right now. There is a work around right now with
$this->sendResponse(new \Nette\Application\Responses\JsonResponse($data, 'application/json; charset=utf-8')); , but it ?should not? work.

There is a discussion of this behavior on Nette Framework Forum (in Czech).

I am willing to write a PR, of somebody decides the solution (you should not be able to set charset under any circumstances vs add ability to set charset transparently).

[dg]

Nette supports only UTF-8.

You can create your own response, send a different encoding and encode json without flag JSON_UNESCAPED_UNICODE, but it should not be part of Nette.

[dg]

Are you saying that there is missing charset=UTF-8? So please send PR and set 'utf-8' here, setContentType($this->contentType, 'utf-8')

[patrickkusebauch]

Yes, that is exactly what I am saying. I will make a PR over the weekend.

[JanTvrdik]

This is more of a Chrome bug than Nette bug because

1. encoding of JSON can be reliable determined from first few bytes
2. only UTF-8 is used in real-world
3. UTF-8 is the default encoding

---

Also the official registration of mime type application/json pretty much says that the charset parameter is pointless for JSON.

[milanobrtlik]

Try this:
$this->payload = ["test"=>"ÝŽáýžřáýž"];
$this->sendPayload();

and you will see Chrome bug.
In real world are used ALL possible encodings. Even the impossible ones.

[patrickkusebauch]

@dg Furthermore, there is a possible bug in Nette\Http\Repsonse, where you can set the charset by callingNette\Http\Response::setContentType('application/json; charset=utf-8', null)instead of Nette\Http\Response::setContentType('application/json', 'charset=utf-8')

[dg]

https://bugs.chromium.org/p/chromium/issues/detail?id=438464

[jahudka]

Well this is just wrong :-( There is no "charset" parameter for the application/json content-type and JSON must be unicode by definition. Setting a charset to an application/json response may break things, like Nittro for example, because some people are trying to follow standards and specs and those specifically say there is no charset for application/json...

[jahudka]

Besides, if you read through the chromium bug report, this is an edge case at best..

1. It only happens to people who have a specific encoding set in their browser, instead of automatic encoding detection; yes, there still might be some people like that, but
2. It only happens if you're looking directly at the JSON data out of context, i.e. by directly opening an API endpoint by typing its address in your browser address bar. If you load the JSON data, say, by AJAX, from a page that already is in UTF-8, then in that page's context the JSON data is interpreted correctly, as demonstrated here (yes, it's Opera, but the behaviour when opening the JSON URLs directly is the same). And who is the only person that will ever see the raw JSON data out of context? Yes, the developer.

So basically what you're arguing is that Nette should output invalid, standards-incompatible responses for the sake of a couple of developers who aren't even able to switch encoding to automatic detection. Neat.

[fprochazka]

@jahudka can you please post a link for the mentioned standards? Anyway, this should be probably reverted as a bug.