Typed persistent parameters

[jtojnar]

Currently, the components’ persistent parameters are only converted to a type when they have default value:

application/src/Application/UI/Component.php

Lines 138 to 139 in 9483f43

	$type = gettype($meta['def']);
	if (!$reflection->convertType($params[$name], $type)) {

Sometimes, the value can only be set dynamically but we would still like for it to be properly converted in loadState.

I propose recognizing typed annotations like @var int @persistent

It would need to be extracted here and then handled in the function above.

I can implement this if you agree.

[dg]

Can you better describe what situation you want to deal with?

[jtojnar]

The VisualPaginator component has two persistent properties: $page and $itemsPerPage. In loadState method, they are assigned to the corresponding properties of Nette\Utils\Paginator. With strict_types on, this fails unless we manually convert the properties to int, which, while being a trivial modification, feels like something that our framework could spare us doing.

And indeed, it does convert the type for us when we set a default value. However, that is not always possible. We can assign the default value 1 for the $page property statically but the default value of $itemsPerPage depends on another property, $itemsPerPageList, which can be modified after the construction of VisualPaginator. In that case it is not right to set default value to some dummy number because then, the component could be internally inconsistent ($itemsPerPageList[$itemsPerPage] needs to exist).

Setting the type to ?int, Nette could easily convert the value of the persistent property in the background like it does with properties that have a default value set, allowing us to clean up the code slightly.

[dg]

I understand, you just need nullable typed property.

I will add them, but I wouldn't probably support the @var annotations, but I would add support for type properties in PHP 7.4