change Route inflectors visibility to public #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
pushed a commit
that referenced
this pull request
Mar 7, 2018
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 3, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 10, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 20, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 20, 2019
dg
pushed a commit
to nette/routing
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis just makes inflectors methods inside routes public. I bumped already in two project that I needed this code when developing some custom routes, and I think others also. In any way can't find anything harmful in this. Was also thinking to extract those methods maybe to RoutingHelper or something like that...