LatteExtension: changed UI\TemplateFactory type to ApplicationLatte\TemplateFactory #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te\TemplateFactory
Member
|
So I hope it's not a BC break. |
dg
reviewed
Feb 16, 2021
Contributor
Author
|
Afaik shouldn't be? Unless user has a factory set to something what cannot be used directly as a type, it should behave in BC compatible manner. |
Member
dg
changed the title
dg
pushed a commit
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latte TemplateFactory have
createTemplate()extended for$classparameter and more accurate return typehint, which are both frequently used. This allowsTemplateFactoryto be autowired byApplicationLatte\TemplateFactorytype and prevent users confusion (like here and here)Also some hint explaining why autowiring does not work when user sees in its DIC that service of requested type is available could be super helpful, but I have no idea how complicated the implementation would be