Skip to content

Parameters added via addParameters() has higher priority (BC break) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Mar 26, 2019
Merged

Parameters added via addParameters() has higher priority (BC break) #56

dg merged 1 commit into from
Mar 26, 2019

Conversation

@dg
Copy link
Member

@dg dg commented Mar 21, 2019

  • BC break? yes

Should have higher priority parameters defined in config file or added by addParameters()?

@solcik
Copy link

solcik commented Mar 21, 2019 •
edited
Loading

For me config files are base and addParameters() should overwrite that.

@dg dg merged commit e1075af into nette:master Mar 26, 2019
@dg dg deleted the pull-priority branch March 26, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dg @solcik