Control characters are not allowed in memcache keys (BC break) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
added a commit
that referenced
this pull request
Dec 14, 2014
dg
added a commit
that referenced
this pull request
Dec 21, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Dec 22, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Dec 22, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Dec 22, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Dec 30, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Jan 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently possible to use any character as a part of memcache key. According to memcache specification https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L48 "the key must not include control characters or whitespace.". This causes problems even in the vanilla installation, as Cache class is using
\x00as a default namespace separator.The issue of disallowed characters is already tackled by FileStorage which deals with it by urlencoding the $key before using it. My solution is pretty much the same, I urlencode the $key before using it.
This solution may cause BC break in custom MemcacheStorage child implementations (that extend from MemcacheStorage).