-
-
Notifications
You must be signed in to change notification settings - Fork 44
SQLiteJournal: filesystem permissions like ordinary file #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't find a more systematic way. |
518aa60 to
b5a505f
Compare
|
I don't like the |
|
What about if ($path !== ':memory:') {
touch($path);
} |
|
@Unlink 👍 for EDIT: or maybe not, I don't know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if fopen returns false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
|
Syscalls of solutions: |
|
What about |
b5a505f to
3f8a80b
Compare
667fb80 to
73d31b8
Compare
SQLiteJournal is used with the FileCache. Seems correct to me, it should behave in the same way as ordinary files.