Selection: added new method whereOr #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meridius
force-pushed
the
added-whereor
branch
2 times, most recently
from
cd4211b to
23ad49e
Compare
meridius
force-pushed
the
added-whereor
branch
from
23ad49e to
fa7d0ed
Compare
src/Database/Table/Selection.php
Outdated
Contributor
There was a problem hiding this comment.
If you invert this condition, you can simply avoid putting whole method body into one large condition.
meridius
force-pushed
the
added-whereor
branch
from
fa7d0ed to
440577d
Compare
src/Database/Table/Selection.php
Outdated
meridius
force-pushed
the
added-whereor
branch
2 times, most recently
from
fe5d58c to
881c210
Compare
Contributor
Author
There was a problem hiding this comment.
Can anyone think of some function which takes at least two parameters and is implemented in all mysql, sqlite and postgesql? Otherwise I'd have to use LOCATE(), which works only on MySQL and that way the whole testcase would be skipped on anything else.
meridius
force-pushed
the
added-whereor
branch
from
881c210 to
4eda4cf
Compare
meridius
force-pushed
the
added-whereor
branch
from
4eda4cf to
afc1637
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
0771c2f to
425ad23
Compare
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
May 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will make creating the OR-ed where conditions easier by passing an (associative) array as its parameter.