Fixed dump issue with non-string values #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Or maybe add new Helper, that will translate column value to the proper type (boolean, string, number, null) |
If you call dump on ResultSet and non-string value (like null) exists, dump will raise TypeError exception on PHP7.1 and newer (maybe even on older version). This add new static dumpVar method, that will try to escape value and return always string.
Contributor
Author
|
@dg ping, if you have any ideas, what should be changed, just give me call :) |
Member
|
I'll make it little bit simpler, ok? ;-) |
dg
pushed a commit
that referenced
this pull request
Sep 14, 2018
If you call dump on ResultSet and non-string value (like null) exists, dump will raise TypeError exception on PHP7.1 and newer (maybe even on older version). This add new static dumpVar method, that will try to escape value and return always string.
dg
pushed a commit
that referenced
this pull request
Sep 14, 2018
If you call dump on ResultSet and non-string value (like null) exists, dump will raise TypeError exception on PHP7.1 and newer (maybe even on older version). This add new static dumpVar method, that will try to escape value and return always string.
Contributor
Author
|
Sure :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call ResultSet::dump with null as column value, it will raise TypeError, so $col should be retyped to string, as htmlspecialchars expects string.