Skip to content

Conversation

@RiKap
Copy link
Contributor

@RiKap RiKap commented Feb 4, 2020

  • bug fix
  • BC break? no

This is just UI bug fix.
I found that Helpers::dumpSql() has problem with bool parameters.
Bool parameters are processed in last step and casted to (string).
Problem is that (string) FALSE is empty string and not 0.
Because of that is dumpSql() able to generate invalid sql like this:

WHERE (`user`.`deleted` = OR `user`.`deleted` IS NULL)

instead of valid:

WHERE (`user`.`deleted` = 0 OR `user`.`deleted` IS NULL)

@dg
Copy link
Member

dg commented Feb 4, 2020

Thanks

@dg dg merged commit 784a573 into nette:master Feb 4, 2020
dg pushed a commit that referenced this pull request Feb 4, 2020
@RiKap RiKap deleted the patch-1 branch February 4, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants