PhpReflection::getParameterType() can handle PHP 7.1 nullable types #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
reviewed
Sep 21, 2016
src/DI/PhpReflection.php
Outdated
| if ($param->hasType()) { | ||
| return (PHP_VERSION_ID >= 70100) ? $param->getType()->getName() : (string) $param->getType(); | ||
| } | ||
| return NULL; |
Contributor
There was a problem hiding this comment.
What about using more shallow condition structure?
if (PHP_VERSION_ID >= 70100) {
return $param->hasType() ? $param->getType()->getName() : NULL;
} elseif (PHP_VERSION_ID >= 70000) {
return $param->hasType() ? (string) $param->getType() : NULL;
}| Assert::same('array', PhpReflection::getParameterType($params[2])); | ||
| Assert::same('callable', PhpReflection::getParameterType($params[3])); | ||
| Assert::null(PhpReflection::getParameterType($params[4])); | ||
| Assert::same('Test\B', PhpReflection::getParameterType($params[5])); |
Contributor
There was a problem hiding this comment.
You should add tests/DI/PhpReflection.getParameterType.php71.phpt (with @phpversion >= 7.1 annotation) with real nullable types.
MartinMajor
force-pushed
the
nullable-types
branch
from
c424cc3 to
4dc1822
Compare
MartinMajor
force-pushed
the
nullable-types
branch
from
4dc1822 to
6a27b1d
Compare
Contributor
Author
|
Updated by JanTvrdik's suggestions. Thanks! |
Member
|
Thank you |
Member
|
What about return type? |
Contributor
Author
|
Yep, it should be updated as well. I'll prepare another PR. |
dg
pushed a commit
that referenced
this pull request
Sep 21, 2016
dg
pushed a commit
that referenced
this pull request
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullable parameter types are prefixed by
?in Reflection in PHP 7.1 which causes that Nette autowiring doesn't work. Even though this behaviour has changed many times in PHP 7.1 ( php/php-src@622d2f4 , php/php-src@8855a2c , php/php-src@f4e68a3 ) this fix uses new preferred way ReflectionNamedType::getName() which looks pretty stable.