generated factories: fix return type #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej21
force-pushed
the
fix/return-type-covariance
branch
2 times, most recently
from
37c02a0 to
bd30fea
Compare
hrach
reviewed
Apr 11, 2017
src/DI/PhpGenerator.php
Outdated
| ->setParameters($this->convertParameters($def->parameters)) | ||
| ->setBody(str_replace('$this', '$this->container', $code)) | ||
| ->setReturnType($def->getClass()); | ||
| ->setReturnType(Reflection::getReturnType($rm)?: $def->getClass()); |
matej21
force-pushed
the
fix/return-type-covariance
branch
from
bd30fea to
116cebc
Compare
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because php does not support return type covariance