Skip to content

Conversation

@janbarasek
Copy link
Contributor

In case of:

public function createServiceMyService(): Model\MyService
{
	$service = new Model\MyService;
	return $service;
}

Generate simplify version:

public function createServiceMyService(): Model\MyService
{
	return new Model\MyService;
}

And in case of simple static service:

public function createServiceMyService(): Model\MyService
{
	$service = Model\MyServiceFactory::getInstance();
	return $service;
}

Generate:

public function createServiceMyService(): Model\MyService
{
	return Model\MyServiceFactory::getInstance();
}

…dependencies.

In case of:

```php
public function createServiceMyService(): Model\MyService
{
	$service = new Model\MyService;
	return $service;
}
```

Generate simplify version:

```php
public function createServiceMyService(): Model\MyService
{
	return new Model\MyService;
}
```

And in case of simple static service:

```php
public function createServiceMyService(): Model\MyService
{
	$service = Model\MyServiceFactory::getInstance();
	return $service;
}
```

Generate:

```
public function createServiceMyService(): Model\MyService
{
	return Model\MyServiceFactory::getInstance();
}
```
@dg dg force-pushed the master branch 3 times, most recently from 4248460 to 2378ea6 Compare July 19, 2019 11:08
@dg
Copy link
Member

dg commented Jul 19, 2019

I think it would be cleaner to deal with this in ServiceDefinition::generateMethod()

@dg dg force-pushed the master branch 4 times, most recently from fecd1fb to 15978c3 Compare July 19, 2019 11:32
@dg dg closed this in 0112da4 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants