ContainerLoader: simplify mutex handling #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
staabm
commented
Oct 24, 2021
Member
|
Some prove that the lock was not released? |
Contributor
Author
|
You mean a unit test? |
Member
|
I think the |
Contributor
Author
|
So the idea is: it is useless because the handle is stored in a local variable which frees the handle and the lock when the variable is going out of scope? |
Member
|
Yeah, exactly. |
staabm
changed the title
Contributor
Author
|
as discussed, I adjusted the PR to remove the UNLOCK line (and added a comment). |
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 26, 2021
dg
pushed a commit
that referenced
this pull request
Oct 26, 2021
dg
added a commit
that referenced
this pull request
Apr 20, 2022
This reverts commit 942e406. See nette/tracy#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code as was before this PR, did not release the file-mutex on e.g. one of theNette\IOExceptionthrowing cases