removeComponent() and getControls() in group

[aleswita]

• bug report? yes
• feature request? no
• version: 2.4.4

Description

I have no idea if is bug or intention. but if I remove component from form, component still exist in group controls.

Steps To Reproduce

protected function createComponentForm(): \Nette\Application\UI\Form {
	$form = new \Nette\Application\UI\Form;

	$form->addGroup("group1");

	$form->addText("input1");

	$form->addText("input2");

	$form->addSubmit("send1");

	$form->removeComponent($form["input1"]);

	bdump($form->getComponents());
	bdump($form->getCurrentGroup()->getControls());

	return $form;
}

[aleswita]

This issue probably caused, why can not add component to the specific position with rendering with groups.

Expected output (without groups):

protected function createComponentForm(): \Nette\Application\UI\Form {
	$form = new \Nette\Application\UI\Form;

	//$form->addGroup("group1");

	$form->addText("input1", "input1");

	$form->addText("input2", "input2");

	$form->addSubmit("send1", "send1");

	$form->addSubmit("send2", "send2");

	$form->addComponent(new \Nette\Forms\Controls\TextInput("input3"), "input3", "send1");

	return $form;
}

Invalid inputs position (with groups):

protected function createComponentForm(): \Nette\Application\UI\Form {
	$form = new \Nette\Application\UI\Form;

	$form->addGroup("group1");

	$form->addText("input1", "input1");

	$form->addText("input2", "input2");

	$form->addSubmit("send1", "send1");

	$form->addSubmit("send2", "send2");

	$form->addComponent(new \Nette\Forms\Controls\TextInput("input3"), "input3", "send1");

	return $form;
}

[dg]

Remove component from form really doesn't remove component from group. Due to the general concept of groups, this can not be changed in 2.4. So I added method remove() and removeOrphans() which removes unused controls.

[aleswita]

@dg tnx!

For rendering problems, describe here: #155 (comment), do I create new issue?

[dg]

Yes. It is much more complicated to solve.