Skip to content

netteForms.js: support for toggling by css class, not only id #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Feb 11, 2019
Merged

netteForms.js: support for toggling by css class, not only id #210

dg merged 1 commit into from
Feb 11, 2019

Conversation

@Ciki
Copy link
Contributor

@Ciki Ciki commented Feb 11, 2019 •
edited by dg
Loading

  • new feature
  • BC break? no

this is useful eg. for controls manually rendered as table cells <td> which have only <tr> valid parent .. if there are multiple cells within table row toggling via id is not feasible (it would toggle all the cells in that row).

Example

$form->addCheckbox('send', 'Ship to address')
	->addCondition($form::FILLED)
		->toggle('body .sendBox');

@Ciki
support for toggling by css class, not only id
654b604 
this is useful eg. for controls manually rendered as table cells `<td>` which have only `<tr>` valid parent .. if there are multiple cells within table row toggling via `id` is not feasible (it would toggle all the cells in that row).
@Ciki Ciki changed the title js: support for toggling by css class, not only id netteForms.js: support for toggling by css class, not only id Feb 11, 2019
@dg
Copy link
Member

dg commented Feb 11, 2019

Thanks

@dg dg merged commit 8e01765 into nette:master Feb 11, 2019
dg pushed a commit that referenced this pull request Feb 11, 2019
@Ciki @dg
support for toggling by CSS selector, not only id (#210)
6a1100d 
this is useful eg. for controls manually rendered as table cells `<td>` which have only `<tr>` valid parent .. if there are multiple cells within table row toggling via `id` is not feasible (it would toggle all the cells in that row).
@dg
Copy link
Member

dg commented Feb 11, 2019

I changed it to full CSS selector.

dg pushed a commit that referenced this pull request Feb 11, 2019
@Ciki @dg
support for toggling by CSS selector, not only id (#210)
2df07d6 
this is useful eg. for controls manually rendered as table cells `<td>` which have only `<tr>` valid parent .. if there are multiple cells within table row toggling via `id` is not feasible (it would toggle all the cells in that row).
dg pushed a commit that referenced this pull request Feb 11, 2019
@Ciki @dg
netteForms: support for toggling by CSS selector, not only id (#210)
f915992 
this is useful eg. for controls manually rendered as table cells `<td>` which have only `<tr>` valid parent .. if there are multiple cells within table row toggling via `id` is not feasible (it would toggle all the cells in that row).
dg pushed a commit that referenced this pull request Feb 19, 2019
@Ciki @dg
netteForms: support for toggling by CSS selector, not only id (#210)
d862717 
this is useful eg. for controls manually rendered as table cells `<td>` which have only `<tr>` valid parent .. if there are multiple cells within table row toggling via `id` is not feasible (it would toggle all the cells in that row).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ciki @dg