Erasing CsrfProtection control value is ignored [Closes #39] #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZZromanZZ
changed the title
Contributor
|
A test case would be nice. |
Contributor
|
this should be somehow solved in csrf control. or by introducing a new interface, or sth else. this is bad design. |
Contributor
Author
|
Yeah, I know this pull request is garbage, but, at least, someone finally noticed :) |
dg
added a commit
that referenced
this pull request
Oct 26, 2014
dg
added a commit
to nette/nette
that referenced
this pull request
Oct 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the problem, but there is better way, I think.
For example, when you use some filter form with two buttons (filter and reset). Reset button submit invokes setting default values -> erasing all values including CsrfProtection -> CsrfProtection fail.