UrlScript: accept option $scriptPath param in constructor #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
force-pushed
the
pr/urlscript_constructor
branch
from
19846e7 to
6bd576d
Compare
JanTvrdik
force-pushed
the
pr/urlscript_constructor
branch
from
6bd576d to
45e99cc
Compare
JanTvrdik
referenced
this pull request
Nov 12, 2016
…al as the class Url (in method getBasePath, ...) [Closes #100] (possible BC break)
Member
|
Can you describe the pain? |
Contributor
Author
|
@dg I had to replace all |
Contributor
Author
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To alleviate the pain caused by 12ac75c I suggest adding optional parameter to UrlScript's constructor.