RequestFactory: when proxy is used, sets default port when HTTP_X_FORWARDED_PORT is not available #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WARDED_PORT is not available
Member
Author
|
@grongor can you help me to add test to RequestFactory.scheme.phpt? |
Contributor
Member
Author
|
@grongor thanks! |
f3l1x
reviewed
Jun 14, 2017
| } else { | ||
| if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) { | ||
| $url->setScheme(strcasecmp($_SERVER['HTTP_X_FORWARDED_PROTO'], 'https') === 0 ? 'https' : 'http'); | ||
| $url->setPort($url->getScheme() === 'https' ? 443 : 80); |
Member
There was a problem hiding this comment.
Wow, it's great, I can remove theses lines.
grongor
referenced
this pull request
Jun 14, 2017
Also added SERVER_NAME in order to prevent port being based on the scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent to create links like
https://example.com:80