Skip to content

Conversation

@dg
Copy link
Member

@dg dg commented Jan 17, 2017

  • bug fix? ~
  • new feature? yes
  • BC break? no

There are use cases where {includeblock} is useful and cannot be substituted by {import}. But the name {includeblock} is misleading. This is attempt to solve it by more understandable {include with blocks 'file.latte'}

Cons: this introduces syntax which is not common in Latte.

https://forum.nette.org/cs/26699-latte-vypis-bloku-do-include

@JanTvrdik
Copy link
Contributor

I hate the syntax. Also include related stuff are changed way too often -> deeper analysis is required.

@dg
Copy link
Member Author

dg commented Jan 17, 2017

Do you have a better idea about syntax?

@JanTvrdik
Copy link
Contributor

Not yet. I don't want to rush this change just to change it in two weeks again.

@dg
Copy link
Member Author

dg commented Jan 17, 2017

I don't know what are you talking about.

@f3l1x
Copy link
Member

f3l1x commented Jan 17, 2017

The syntax {include-with-blocks} is forbidden?

@dg
Copy link
Member Author

dg commented Jan 18, 2017

{include-with-blocks} is not common in Latte too. More expectable is {includewithblocks} (hard to read) or {includeWithBlocks}.

@dg dg force-pushed the includeblock branch 3 times, most recently from dc17ef3 to 7550eb3 Compare January 19, 2017 11:49
@dg dg force-pushed the master branch 4 times, most recently from 118e433 to 2f2e445 Compare January 26, 2017 17:13
@dg dg force-pushed the master branch 3 times, most recently from beacf44 to ee18dfc Compare February 2, 2017 01:58
@dg dg force-pushed the master branch 2 times, most recently from e83378c to 1ed4097 Compare July 21, 2017 19:45
@dg dg force-pushed the master branch 3 times, most recently from 91a8964 to d4f519e Compare March 21, 2018 17:41
@dg dg force-pushed the master branch 14 times, most recently from 04cdb42 to 1870016 Compare November 21, 2020 14:17
@dg dg force-pushed the master branch 9 times, most recently from f1158da to 7957380 Compare November 23, 2020 13:46
@dg dg changed the base branch from master to v2.9 November 23, 2020 15:04
@dg
Copy link
Member Author

dg commented Nov 23, 2020

Changed to {include file.latte with blocks}

@dg dg merged commit d147632 into nette:v2.9 Nov 23, 2020
@dg dg deleted the includeblock branch November 23, 2020 15:05
dg added a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants