Added RobotLoader::excludeDirectory(), docs #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
reviewed
Jan 19, 2017
| * Excludes path or paths from list. | ||
| * @param string|string[] absolute path | ||
| * @return static | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Yes, it could be. But if so, it should be done also in RobotLoader::addDirectory(). The functions are almost the same.
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Jan 23, 2017
Closed
dg
pushed a commit
that referenced
this pull request
Jan 23, 2017
dg
pushed a commit
that referenced
this pull request
Jan 23, 2017
dg
pushed a commit
that referenced
this pull request
Jan 23, 2017
dg
pushed a commit
that referenced
this pull request
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FR #8
I also think it is useful for it is more intuitive than using
netterobots.txt. A few months ago I needed to do the same thing and because my only documentation was API reference at the time, I did not know about possibility to usenetterobots.txtand I had to move that directory to an other place.