Hashes with cost 31 will never be verified as valid

[josefsabl]

Here
https://github.com/nette/security/blob/master/src/Security/Passwords.php#L57

There should be less than 32.

[milo]

That's true. Are you capable to send a fix?

[josefsabl]

I'll try my first pull request :-)

[fprochazka]

@josefsabl let us know if you'll need any guidance

[josefsabl]

There it goes: #3

But this sentence baffles me: Add more commits by pushing to the master branch on josefsabl/security.

Does it mean that pushing commits to my master will add more commits to this pull request? So I should have created separater branch for the fix?

[fprochazka]

@josefsabl yes, that's why you should create new branch for each pullrequest.

[josefsabl]

Okay, lesson learned :) But what to do now? Should I just leave it like that and just delete my fork or will you reject the request and I will prepare a new one?

[fprochazka]

@josefsabl if you don't wanna bother with closing it and creating a new pull, don't push to your master branch untill the current pull is merged.

[josefsabl]

Already did it. At least it's done properly :-) Thanks for advice.

[fprochazka]

@josefsabl awesome! And now you know how to send pulls :)

[josefsabl]

Yeah, thanks :)