TestCase: data provider supports \Traversable

[jiripudil]

I've found that if you want to return some more complex structures from a data provider or even do some other logic to it inbetween, generators seem to be a more convenient approach than arrays.

In my case, I need to test data validation of a third-party API, generating a valid request and breaking it in a lot of slightly different ways, and generators just seem to be much more expressive:

public function dataProvider()
{
    $request = $this->createValidRequest();
    unset($request['title']);
    yield [$request, 'Missing parameter title'];

    $request = $this->createValidRequest();
    unset($request['description']);
    yield [$request, 'Missing parameter description'];

    // ...
}

[dg]

IMHO version check is not needed

[jiripudil]

ok, I'll get rid of it

[fprochazka]

👍

[milo]

What about to support \Traversable instead of \Generator?

[jiripudil]

@milo I thought about it, but didn't find any use case for Traversables other than Generators. But yeah, why not, while I'm at it :)

[jiripudil]

I've added support for Traversable and squashed the branch into a single commit.

[dg]

Why leading slash?

[jiripudil]

removed

[milo]

Imho ready to merge. I left few CS hint comments.

[jiripudil]

@milo I've fixed the CS compliance. Should I squash it now?

[milo]

Yes please.

[jiripudil]

Squashed.

[milo]

Thank you.