Code coverag engine name instead of availability flag #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dg
reviewed
Feb 19, 2019
src/Runner/PhpInterpreter.php
Outdated
| } | ||
|
|
||
|
|
||
| public function getCodeCoverageEngine(): ?string |
Member
There was a problem hiding this comment.
What about getCodeCoverageEngines(): array ?
Member
Author
There was a problem hiding this comment.
And choose the one in CliTester? 👍
milo
force-pushed
the
cc-engine-detect
branch
6 times, most recently
from
8d1250c to
06b76f0
Compare
milo
force-pushed
the
cc-engine-detect
branch
from
06b76f0 to
84c6919
Compare
dg
pushed a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #396
CliRunner may do specific Code Coverage engine setup.