Fix integer-indexed cases

[vojtech-dobes]

• bug fix
• BC break? not sure to be honest
• doc PR: shouldn't be needed

Description

Currently when PHP @dataProvider returns integer-indexed cases (simply array), in each run the first case is used.

Example

Given following test:

[$expected, $actual] = Tester\Environment::loadData();
Tester\Assert::same($expected, $actual);

With following data provider, all 3 cases will fail:

return [
    ['foo', 'bar'],
    ['foo', 'foo'],
    ['foo', 'foo'],
];

With following data provider, all 3 cases will succeed:

return [
    ['foo', 'foo'],
    ['foo', 'bar'],
    ['foo', 'bar'],
];

Summary

That's what this PR fixes :)

[milo]

Uff, this is nasty bug. Thank you!

[milo]

The is_int() condition is there because I thought, integer indexed items should never be filtered out. The bug is hidden in here

tester/src/Framework/Environment.php

Line 230 in 43743fb

return reset($data);

I have to thing about it.

[vojtech-dobes]

@milo Awesome, thanks!