Delay panel rendering #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
6 times, most recently
from
7f3fd63 to
bbc898e
Compare
JanTvrdik
force-pushed
the
pr/lazy_panel_rendering
branch
from
2d53b24 to
3552156
Compare
JanTvrdik
force-pushed
the
pr/lazy_panel_rendering
branch
from
3552156 to
5ee0d72
Compare
Contributor
Author
|
@dg This is now ready to merge from my point of view. |
Contributor
Author
|
It did not work before, so it's fine 😄 |
Member
|
Great! |
Contributor
|
Thanks @JanTvrdik - this is awesome! |
Member
|
@JanTvrdik there is problem when panel contains dumps with LIVE => TRUE, it is not inited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how we delay rendering of invisible dumps we should delay rendering of invisible panels and render them the first time they became visible. This is especially important when bar panel contains a lot of HTML (for example query log).
What do you think?