Allow adding of custom icons to panel header. By being explicit about what the "window" icon does, we can add others without them triggering this action. #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… what the "window" icon does, we can add others without them triggering this action.
dg
force-pushed
the
master
branch
4 times, most recently
from
d13a9ce to
7f24887
Compare
Contributor
Author
|
Hey @dg - is there any reason not to include this? I have been running it for several months now and it works fine and really helps out - it lets other add other icons to the panels - in my case I added "large window" and "small window" icons so it's easy to expand / contract the panel as needed. |
Member
|
I just overlooked it. |
Contributor
Author
|
Thanks very much! |
Member
|
Thanks for PR :) |
dg
pushed a commit
that referenced
this pull request
Mar 22, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg
pushed a commit
that referenced
this pull request
Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg
pushed a commit
that referenced
this pull request
Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg
pushed a commit
that referenced
this pull request
Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg
pushed a commit
that referenced
this pull request
Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.