Skip to content

Bar: opens link to new window #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 3 commits into from
Jan 14, 2020
Merged

Bar: opens link to new window #400

dg merged 3 commits into from
Jan 14, 2020

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jan 12, 2020

  • new feature
  • BC break? no

Added icon for open link to new window:

Snímek obrazovky 2020-01-12 v 22 35 44

@dg
Copy link
Member

dg commented Jan 12, 2020

I think it's better to open it in a new window every time. The icon seems to belong to the link.

@janbarasek
Copy link
Contributor Author

janbarasek commented Jan 13, 2020

@dg It's make sense. Fixed.

dg
dg reviewed Jan 14, 2020
View reviewed changes
@dg
Copy link
Member

dg commented Jan 14, 2020

Thanks

@dg dg merged commit 51bf1f0 into nette:master Jan 14, 2020
@dg dg changed the title Content: Add link as new window Bar: opens link to new window Jan 14, 2020
dg pushed a commit that referenced this pull request Jan 14, 2020
@janbarasek @dg
Bluescreen: opens link to new window (#400)
f7ee5c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dg dg dg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbarasek @dg