Info panel JIT #440
Merged
Info panel JIT #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8 is supports JIT. Would be nice to show if its enabled.
dg
force-pushed
the
master
branch
8 times, most recently
from
55360f2 to
867c2b6
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
76bd58c to
b9d29d3
Compare
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 14, 2020
dg
pushed a commit
that referenced
this pull request
Oct 14, 2020
This should be improved a bit more, because the default configuration and behavior is weird. Jit is enabled by default (in tracing), but buffer_size is 0 (that is its default value) and the zero value disables JIT. Then JIT is not enabled although $opcache['jit']['enabled'] is true. It should be enough to check for $jit['buffer_size'] > 0 |
Member
|
@diegosardina I tried to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8 is supports JIT. Would be nice to show if its enabled.