-
-
Notifications
You must be signed in to change notification settings - Fork 221
Logger: also drop 'object' before serialization #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What you mean by which is awesomely supported for many years? Supported by PHP? |
Supported by Tracy. |
|
Look, I don't understand you at all :-) I've never seen an 'object' field in exception callstack. Maybe you have a PHP extension that puts it there, PHP doesn't do that https://www.php.net/manual/en/exception.gettrace.php |
|
@dg Yes, there is no simple way to get it there, only |
|
I'm sorry, but I feel like you're wasting my time. There is no field. |
|
@dg that was definitely not my intention, so sorry for that. But can you please tell me, is there some reason why same argument wouldn't apply for existence of this:
I was basing my reasoning entirely on existence of this "support". |
|
Ah, I get it. It is probably some historical relict… |
When stack trace contains
'object'field (which is awesomely supported for many years :) ),Loggerdoesn't get rid of it before serialization when establishing exception file name. This PR removes the'object'field in same way as'args'is being dropped already.