isUrl validator returns false on "https://example.com?query", but true on "https://example.com/?query"

[thorewi]

Hi,

I think in both cases it should return "true".

[JanTvrdik]

I think in both cases it should return "true".

Based on what evidence / standard?

[thorewi]

I think there is no RFC or other standard for what URL is and you can find many opinions across the internet but browser and curl supports "url" with missing slash and I think it's quite widely used.

[JanTvrdik]

I think there is no RFC or other standard for what URL is

There are actually multiple standards.

[thorewi]

I know there is one for URI (http://www.faqs.org/rfcs/rfc2396.html) where URL is mentioned but not precisely specified... anyway, I think if someone writes https://example.com?query he always means https://example.com/?query so it should be valid... even filter_var('http://example.com?query', FILTER_VALIDATE_URL); succeeds

[JanTvrdik]

😞

RFC 2396 has been obsoleted by RFC 3986 which specifically allows for "path component to be empty".

There is also a living URL standard by WHATWG which also allows for empty path.

[thorewi]

so should I create PR?

[JanTvrdik]

Yes, that would be awesome.