Image::place() converts percentage arguments to numeric value #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
Author
|
Done |
Contributor
Author
|
Is anything else needed? |
Member
|
abs() is missing |
Contributor
Author
|
Fixed |
JanTvrdik
approved these changes
Oct 23, 2016
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 26, 2016
dg
reviewed
May 2, 2017
src/Utils/Image.php
Outdated
| { | ||
| if (is_string($newWidth) && substr($newWidth, -1) === '%') { | ||
| $newWidth = (int) round($srcWidth / 100 * abs($newWidth)); | ||
| $newWidth = (int) round($srcWidth / 100 * substr($newWidth, 0, -1)); |
Contributor
Author
There was a problem hiding this comment.
8683a0b was merged. abs is present in that commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility with PHP 7.1 as it caused
E_NOTICE: A non well formed numeric value encounteredin Image.php:474.